Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YQ-3460 fix error attempt to read after eof #7889

Conversation

GrigoriyPA
Copy link
Collaborator

@GrigoriyPA GrigoriyPA commented Aug 16, 2024

Changelog entry

Fix error attempt to read after eof

Changelog category

  • Bugfix

Additional information

Synched clickhouse fix:
ClickHouse/ClickHouse@85fa372

@GrigoriyPA GrigoriyPA requested a review from a team as a code owner August 16, 2024 08:34
@GrigoriyPA GrigoriyPA requested a review from Hor911 August 16, 2024 08:35
Copy link

github-actions bot commented Aug 16, 2024

2024-08-16 08:38:52 UTC Pre-commit check for 428074b has started.
2024-08-16 08:41:32 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-16 08:46:51 UTC Build successful.

Copy link

github-actions bot commented Aug 16, 2024

2024-08-16 08:38:55 UTC Pre-commit check for 428074b has started.
2024-08-16 08:41:35 UTC Check linux-x86_64-release-asan is running...
2024-08-16 09:32:17 UTC Check cancelled

Copy link

github-actions bot commented Aug 16, 2024

2024-08-16 08:40:57 UTC Pre-commit check for 428074b has started.
2024-08-16 08:43:49 UTC Check linux-x86_64-relwithdebinfo is running...
2024-08-16 09:32:18 UTC Check cancelled

@GrigoriyPA GrigoriyPA force-pushed the YQ-3460-fix-error-attempt-to-read-after-eof branch from a074915 to f73fa66 Compare August 16, 2024 09:31
@GrigoriyPA GrigoriyPA requested a review from a team as a code owner August 16, 2024 09:31
Copy link

github-actions bot commented Aug 16, 2024

2024-08-16 09:33:29 UTC Pre-commit check for f1ecce3 has started.
2024-08-16 09:37:10 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-08-16 10:52:36 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
38690 33337 0 9 5313 31

2024-08-16 10:56:01 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟢 2024-08-16 11:04:40 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
54 (only retried tests) 26 0 0 0 28

🟢 2024-08-16 11:04:47 UTC Build successful.
🟢 2024-08-16 11:05:20 UTC ydbd size 8.1 GiB changed* by +47.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: d569f4b merge: f1ecce3 diff diff %
ydbd size 8 733 058 008 Bytes 8 733 106 568 Bytes +47.4 KiB +0.001%
ydbd stripped size 475 302 856 Bytes 475 308 360 Bytes +5.4 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@GrigoriyPA GrigoriyPA requested a review from vitstn August 16, 2024 09:33
Copy link

github-actions bot commented Aug 16, 2024

2024-08-16 09:33:52 UTC Pre-commit check for f1ecce3 has started.
2024-08-16 09:36:47 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-16 09:46:13 UTC Build successful.

@GrigoriyPA GrigoriyPA requested a review from dorooleg August 16, 2024 09:33
@github-actions github-actions bot added bugfix and removed bugfix labels Aug 16, 2024
Copy link

github-actions bot commented Aug 16, 2024

2024-08-16 09:38:15 UTC Pre-commit check for f1ecce3 has started.
2024-08-16 09:40:56 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-16 11:59:14 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9855 9790 0 8 22 35

🟢 2024-08-16 12:00:35 UTC ydbd size 5.5 GiB changed* by +38.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 8796c8a merge: f1ecce3 diff diff %
ydbd size 5 878 663 528 Bytes 5 878 703 408 Bytes +38.9 KiB +0.001%
ydbd stripped size 1 476 901 456 Bytes 1 476 910 800 Bytes +9.1 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@GrigoriyPA GrigoriyPA added the rebase-and-check Rebase PR with the current base branch and check label Aug 16, 2024
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Aug 16, 2024
Copy link

github-actions bot commented Aug 16, 2024

2024-08-16 13:42:49 UTC Pre-commit check for 2325abb has started.
2024-08-16 13:46:15 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-16 13:51:29 UTC Build successful.

Copy link

github-actions bot commented Aug 16, 2024

2024-08-16 14:02:01 UTC Pre-commit check for 2325abb has started.
2024-08-16 14:05:02 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-08-16 15:23:23 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
38937 33587 0 6 5312 32

2024-08-16 15:26:52 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟢 2024-08-16 15:33:54 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
52 (only retried tests) 24 0 0 0 28

🟢 2024-08-16 15:34:01 UTC Build successful.
🟢 2024-08-16 15:34:36 UTC ydbd size 8.1 GiB changed* by +62.8 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 04beb79 merge: 2325abb diff diff %
ydbd size 8 732 320 544 Bytes 8 732 384 888 Bytes +62.8 KiB +0.001%
ydbd stripped size 475 278 152 Bytes 475 280 392 Bytes +2.2 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Aug 16, 2024

2024-08-16 14:02:49 UTC Pre-commit check for 2325abb has started.
2024-08-16 14:06:16 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-16 16:09:09 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10099 10035 0 10 22 32

🟢 2024-08-16 16:10:01 UTC Build successful.
🟢 2024-08-16 16:10:30 UTC ydbd size 5.5 GiB changed* by +5.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: f6476d4 merge: 2325abb diff diff %
ydbd size 5 877 069 032 Bytes 5 877 074 648 Bytes +5.5 KiB +0.000%
ydbd stripped size 1 476 588 112 Bytes 1 476 588 688 Bytes +576 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@GrigoriyPA GrigoriyPA merged commit cb0ca90 into ydb-platform:main Aug 16, 2024
15 of 18 checks passed
@GrigoriyPA GrigoriyPA deleted the YQ-3460-fix-error-attempt-to-read-after-eof branch August 16, 2024 16:34
GrigoriyPA added a commit to GrigoriyPA/ydb that referenced this pull request Aug 16, 2024
GrigoriyPA added a commit to GrigoriyPA/ydb that referenced this pull request Aug 16, 2024
GrigoriyPA added a commit to GrigoriyPA/ydb that referenced this pull request Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants